Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix tests thread count #1868

Merged
merged 18 commits into from
Nov 1, 2023
Merged

chore: Fix tests thread count #1868

merged 18 commits into from
Nov 1, 2023

Conversation

gurinderu
Copy link
Contributor

@gurinderu gurinderu commented Oct 28, 2023

Description

Remove test-threads property from the ci profile for using test-threads = "num-cpus" from the default profile

Motivation

"Hardcoded" thread count value can be the reason of some failed tests in the processor count < 10

Related Issue(s)

[Cite any related issues or feature requests here, using GitHub issue links.]

Proposed Changes

[List the specific changes and additions introduced by this pull request.]

Screenshots (if applicable)

[Add any relevant screenshots or animated GIFs to showcase the changes.]

Additional Notes

[Provide any additional information or context that may be helpful for the reviewer.]

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@gurinderu gurinderu changed the title Fix tests chore: Fix tests thread count Oct 28, 2023
@gurinderu gurinderu marked this pull request as draft October 29, 2023 13:06
@gurinderu gurinderu force-pushed the fix_tests branch 2 times, most recently from bf84acb to a54a032 Compare October 30, 2023 09:47
@gurinderu gurinderu marked this pull request as ready for review October 30, 2023 10:31
@gurinderu gurinderu requested a review from folex October 30, 2023 11:49
@folex folex added the e2e Run e2e workflow label Oct 30, 2023
@gurinderu gurinderu enabled auto-merge (squash) October 30, 2023 17:44
@gurinderu gurinderu merged commit 5999ea5 into master Nov 1, 2023
14 checks passed
@gurinderu gurinderu deleted the fix_tests branch November 1, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants